Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job creation timestamp to job annotations #4026

Open
5 of 9 tasks
helayoty opened this issue May 22, 2023 · 15 comments
Open
5 of 9 tasks

Add job creation timestamp to job annotations #4026

helayoty opened this issue May 22, 2023 · 15 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@helayoty
Copy link
Member

helayoty commented May 22, 2023

Enhancement Description

  • One-line enhancement description (can be used as a release note): Add new annotation JobCreationTimestampAnnotation to the batch API.
  • Kubernetes Enhancement Proposal:
  • Discussion Link: Inject schedule name into newly created job kubernetes#108609
  • Primary contact (assignee): @helayoty
  • Responsible SIGs: sig-apps
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): N/A
    • Beta release target (x.y): 1.28
    • Stable release target (x.y):

Note: We will release the feature directly in the Beta state since there is no benefit in having an alpha release, as we are simply adding a new annotation which is very little risk (unlike removing an
existing one).

@helayoty
Copy link
Member Author

/sig apps
/assign

@soltysh
Copy link
Contributor

soltysh commented May 30, 2023

/stage beta
/milestone v1.28
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label May 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 30, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 30, 2023
@npolshakova
Copy link

npolshakova commented May 30, 2023

Hi @helayoty 👋, Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #4027 will address some of these issues.

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@helayoty
Copy link
Member Author

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire

@npolshakova This section requires to have reviewers from the
prod-readiness-approvers
team which I already added to the reviewers/approvals list.

@npolshakova
Copy link

Hi @helayoty, looks like now that the PRR is approved and #4027 has gone in this enhancement is now tracked for 1.28!

@Rishit-dagli
Copy link
Member

Hello @helayoty 👋, 1.28 Docs Lead here.

Could you please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@helayoty
Copy link
Member Author

helayoty commented Jul 3, 2023

Hello @helayoty 👋, 1.28 Docs Lead here.

Could you please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @Rishit-dagli , PR has been created. kubernetes/website#41857

@sftim
Copy link
Contributor

sftim commented Jul 6, 2023

@npolshakova
Copy link

Hey again @helayoty 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@soltysh
Copy link
Contributor

soltysh commented Jul 12, 2023

@npolshakova all the PRs are listed in the issue description, we try to keep up-to-date, the only one remaining PR is docs kubernetes/website#41857 but that shouldn't block atm.

@Atharva-Shinde
Copy link
Contributor

Hey @helayoty 👋 Enhancements Lead here,
With kubernetes/kubernetes#118137 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze!

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jan 16, 2024
@atiratree
Copy link
Member

@helayoty are you able to work on graduating this to GA in 1.30?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Backlog
Development

No branches or pull requests

10 participants