New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Static Policy Proposal - Spread HT across physical CPUs #4176
Comments
/sig node |
/cc |
/stage alpha Applying the milestone as discussed at SIG Node meeting this week |
Hello 👋 1.30 Enhancements Lead here, I'm closing milestone 1.29 now, /milestone clear |
Sounds good. I will follow the instruction and move it to v1.30. We plan to polish it for further review. |
@salehsedghpour This is the initial issue and the PR is not merged yet. Could you help add v1.30 milestone? @SergeyKanzhelev @ffromani We will put some time to address all the comments recently |
Thanks for the info @Jeffwan, may you please follow it up so that you could also have the |
/stage alpha As discussed this is conditioned on the discussion on whether NRI approach will work better for this scenario |
/label lead-opted-in |
PRR reviewer here, is there a KEP PR for 1.30 for this enhancement? |
Hello @Jeffwan 👋, v1.30 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we need to do the following:
The status of this enhancement is marked as |
@sreeram-venkitesh Thanks for the reminder. All the TODO items have been addressed and it's pending review. |
Hello 👋, v1.30 Enhancements team here. Unfortunately, this enhancement did not meet requirements for enhancements freeze. If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks! |
/milestone clear |
@sreeram-venkitesh @salehsedghpour I filed an exception and waiting for sig-node to approve it. |
Hello @Jeffwan! Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? |
Hi @Jeffwan , 👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
@celestehorgan kubernetes/website#45216 I have filed placeholder PRs for doc and blog change. |
Hey again @Jeffwan 👋 v1.30 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024. Here's where this enhancement currently stands:
For this enhancement, I was not able to find the PRs for the code changes in k/k. Please let me know of the PRs that we should track and also update the issue description with the same. Currently the KEP is marked as As always, we are here to help if any questions come up. Thanks! |
@Jeffwan Please let me know which all PRs needs to be tracked for the code freeze. The code freeze is tomorrow. |
@sreeram-venkitesh kubernetes/kubernetes#123733 here the PR. I am trying to polish all the tests and gather feedbacks from reviewers. It's a little bit late but I will spend most of time today to finish it |
Hello @Jeffwan 👋 Enhancements team here, Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the If you still wish to progress this enhancement in /milestone clear |
@salehsedghpour The code are in good shape now and I have few rounds discussion with the reviewers to move forward the feature. If we do can deliver the high-quality code in 1 day, I will file the exception. Thanks. |
Enhancement Description
k/enhancements
) update PR(s): KEP-4176: A Static Policy Option to spread hyperthreads across physical CPUs #4177k/k
) update PR(s):k/website
) update PR(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: