Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PSI based on cgroupv2 #4205

Open
1 of 5 tasks
ndixita opened this issue Sep 11, 2023 · 28 comments
Open
1 of 5 tasks

Support PSI based on cgroupv2 #4205

ndixita opened this issue Sep 11, 2023 · 28 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@ndixita
Copy link
Contributor

ndixita commented Sep 11, 2023

Enhancement Description

  • One-line enhancement description (can be used as a release note): Integrating PSI metrics in K8s and using those to set node conditions.
  • Kubernetes Enhancement Proposal:
  • Discussion Link:
  • Primary contact (assignee): @ndixita
  • Responsible SIGs: sig-node
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.30
    • Beta release target (x.y):
    • Stable release target (x.y):
  • Alpha

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 11, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 14, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.29
/label lead-opted-in
/stage alpha

@ndixita please fill up more details in the issue description. Accepting as we discussed at SIG Node meeting this week

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 15, 2023
@tzneal
Copy link
Contributor

tzneal commented Sep 22, 2023

/cc

@rayandas
Copy link
Member

Hello @ndixita 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • The latest readme template has more items in production readiness review questionnaire that need to be addressed.
  • The status should be marked as implementable in the kep.yaml file.
  • Ensure that the PR including the production readiness review has been reviewed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rayandas
Copy link
Member

rayandas commented Oct 4, 2023

Hi @ndixita 👋🏽 checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.
It looks like PR #4230 will address most of the requirements. Let me know if I missed anything. Thanks.

@ndixita
Copy link
Contributor Author

ndixita commented Oct 5, 2023

The KEP PR is updated, and the comments are resolved. I am waiting for PRR review

@npolshakova
Copy link

With KEP PR #4230 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

@katcosgrove
Copy link

Hey there @ndixita! 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@katcosgrove
Copy link

Hi again @ndixita! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@rayandas
Copy link
Member

Hey again @ndixita 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs of this KEP under the stable section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. ✌️ Thanks!

@a-mccarthy
Copy link

Hi @ndixita, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@ndixita
Copy link
Contributor Author

ndixita commented Oct 30, 2023

@a-mccarthy This feature is postponed to 1.30 release

@npolshakova
Copy link

Hello @ndixita 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Nov 1, 2023
@amannijhawan
Copy link

This would be quite useful to have as we can use the psi metrics as a good proxy for memory pressure and potential for OOMKILL.

Thanks
Aman

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 26, 2024
@salehsedghpour
Copy link
Contributor

Hello @ndixita , 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@mrunalp
Copy link
Contributor

mrunalp commented Feb 7, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 7, 2024
@tjons
Copy link

tjons commented Feb 8, 2024

Hello @ndixita 👋, Enhancements team here.

Please ignore my previous message, I had missed your PRR.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ndixita
Copy link
Contributor Author

ndixita commented Feb 8, 2024

@tjons this issue is marked for alpha stage in 1.30

@tjons
Copy link

tjons commented Feb 9, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@drewhagen
Copy link
Member

drewhagen commented Feb 15, 2024

Hello @ndixita 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@fkautz
Copy link
Member

fkautz commented Feb 16, 2024

Hi @ndixita

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@ndixita
Copy link
Contributor Author

ndixita commented Feb 19, 2024

@fkautz This change will mostly not make it to 1.30 as it is dependent on a runc version. Hence I am not opting for a blog yet.

@drewhagen
Copy link
Member

drewhagen commented Feb 22, 2024

Hello @ndixita 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Hello @ndixita! The deadline to open a doc PR is due today.
Just to clarify in regard to your last comment, are we thinking about moving this enhancement to 1.31? If not sure, could we open a placeholder docs PR now and that could always roll over with this KEP? Thanks!

@dims
Copy link
Member

dims commented Feb 22, 2024

@ndixita this one right? opencontainers/runc#3900 - looks like that would be runc 1.2.0 (which still has many blockers to get through - opencontainers/runc#4114)

@ndixita
Copy link
Contributor Author

ndixita commented Feb 23, 2024

@dims that's correct. I will probably request for removal of 1.30 milestone. @drewhagen yes this will be in 1.31 milestone given it has a lot of blockers.

@dims
Copy link
Member

dims commented Feb 23, 2024

/milestone v1.31

happy to kick the can down the road

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Removed from Milestone
Status: Removed from Milestone
Development

No branches or pull requests