Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ProcMount option #4265

Open
3 of 8 tasks
haircommander opened this issue Oct 2, 2023 · 24 comments
Open
3 of 8 tasks

add ProcMount option #4265

haircommander opened this issue Oct 2, 2023 · 24 comments
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@haircommander
Copy link
Contributor

haircommander commented Oct 2, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 2, 2023
@haircommander
Copy link
Contributor Author

replaces kubernetes/community#1934
/sig node
/sig auth

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2023
@mrunalp
Copy link
Contributor

mrunalp commented Oct 3, 2023

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 3, 2023
@AnaMMedina21
Copy link

Hola @haircommander 👋, v1.29 Enhancements team here.

I am just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2023..

This enhancement is targeting stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { v1.29}. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

The status of this enhancement is marked as Tracked for Enhancements Freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova npolshakova added this to the v1.29 milestone Oct 4, 2023
@npolshakova
Copy link

Sorry for the confusion @haircommander, this is actually currently At Risk for Enhancement Freeze until #4266 is approved. We'll update the status once the PR goes in. Let me know if you have any questions- Thanks!

@npolshakova
Copy link

Hello 👋, 1.29 Enhancements Lead here.
Unfortunately, this enhancement did not meet requirements for v1.29 enhancements freeze.
Feel free to file an exception to add this back to the release tracking process.

#4266 is awaiting PRR approval. Please file an exception and once the PRR review is complete this should fulfill all the enhancement freeze requirements.

Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Oct 6, 2023
@sftim
Copy link
Contributor

sftim commented Oct 6, 2023

@haircommander, what's the “One-line enhancement description” for this KEP?

@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2023

@npolshakova https://groups.google.com/g/kubernetes-sig-release/c/emPOBgXxu0Q/m/JxEx-ZrcBgAJ?utm_medium=email&utm_source=footer

Your updated deadline to make any changes to your KEP is 18:00 PST Monday 9th October 2023.

The exception is approved by v1.29 release team. However, we may miss the deadline again 🤣.

@npolshakova
Copy link

@pacoxu It looks like this won't be making it into 1.29 from the slack discussion: https://kubernetes.slack.com/archives/C2C40FMNF/p1697033013866149?thread_ts=1696609849.513439&cid=C2C40FMNF

@stlaz
Copy link
Member

stlaz commented Nov 20, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 20, 2023
@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@haircommander
Copy link
Contributor Author

@SergeyKanzhelev @mrunalp a little late but I have decided to update the KEP. can you PTAL and opt-in as discussed in sig node meeting?

@mrunalp
Copy link
Contributor

mrunalp commented Feb 2, 2024

/stage beta
/milestone v1.30
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@tjons
Copy link

tjons commented Feb 6, 2024

Hello @haircommander 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage beta for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • Merge the updates to the KEP readme into the k/enhancements repo.
  • Complete the PRR review process and merge it into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@tjons
Copy link

tjons commented Feb 8, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@Checksumz
Copy link

Hi @haircommander ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Vyom-Yadav commented Feb 15, 2024

Hello @haircommander 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

At a minimum, we'll need bumping ProcMountType feature gate to beta in docs, so marking as Need Docs. If there are some logical changes, we'll need a PR for that too. Thanks!

Also, I edited the issue desc to update the target version :)

- Beta release target (x.y): 1.29
+ Beta release target (x.y): 1.30

@tjons
Copy link

tjons commented Feb 25, 2024

Hey again @haircommander 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PR is open and needs to be merged before code freeze:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@tjons
Copy link

tjons commented Mar 6, 2024

Hey @haircommander - code freeze is ~6 hours away! We still need kubernetes/kubernetes#123303 to merge before freeze or this will require an exception.

@haircommander
Copy link
Contributor Author

Thanks for the heads up! I will file an exception

@salehsedghpour
Copy link
Contributor

Hello @haircommander 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 6, 2024
@MaryamTavakkoli
Copy link

/milestone v1.30

@k8s-ci-robot
Copy link
Contributor

@MaryamTavakkoli: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@salehsedghpour
Copy link
Contributor

With the exception request being approved, this enhancement is now marked as tracked for code freeze.

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 7, 2024
@haircommander
Copy link
Contributor Author

/stage alpha

(retargeted at alpha)

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Removed from Milestone
Status: Tracked for Doc Freeze
Status: In Review
Development

No branches or pull requests