Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom profile in kubectl debug #4292

Open
3 of 4 tasks
ardaguclu opened this issue Oct 13, 2023 · 13 comments
Open
3 of 4 tasks

Custom profile in kubectl debug #4292

ardaguclu opened this issue Oct 13, 2023 · 13 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@ardaguclu
Copy link
Member

ardaguclu commented Oct 13, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 13, 2023
@ardaguclu
Copy link
Member Author

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2023
@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2024

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 16, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2024

/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status lead-opted-in Denotes that an issue has been opted in to a release labels Jan 16, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 26, 2024

/assign @ardaguclu

@tjons
Copy link

tjons commented Jan 31, 2024

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • Add graduation criteria to the KEP readme.
  • Merge the KEP readme into k/enhancements.
  • Complete the PRR review process and merge it into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ardaguclu
Copy link
Member Author

@tjons thanks for checking the KEP. But I have added graduation criteria as you can see in https://github.com/kubernetes/enhancements/pull/4293/files#diff-708a3d9c4718ca7f3da37b08c6cbee5ff7fc7df4f496783dd213b7abf0f2c216R98, do you mean adding somewhere else?.

@tjons
Copy link

tjons commented Jan 31, 2024

@ardaguclu whoops, missed that in the diff! thanks for updating me. I've updated my commend accordingly.

@tjons
Copy link

tjons commented Feb 8, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@natalisucks
Copy link

Hi @ardaguclu,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Hello @ardaguclu 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

Going through the changes this PR entails, we'll need a docs PR. Marking this as Need Docs. Thanks for this cool feature!

@tjons
Copy link

tjons commented Feb 25, 2024

Hey again @ardaguclu 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@tjons
Copy link

tjons commented Mar 6, 2024

Hello @ardaguclu 👋, Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.30 Code Freeze!

@Starttoaster
Copy link

Starttoaster commented Mar 30, 2024

This feature makes the kubectl debug command actually useful to me, so thank you for it. My team has always been somewhat turned-off from building their applications in shell-less base images because it was really annoying and difficult to runtime debug those containers, so being able to mount data volumes and such in the debug container will be a huge security win for us, I think. Couple of suggestions but I can't overstate how I'm already happy with the current state of it:

  • It'd be nice if the file pointed to with the --custom flag could also be yaml (I'm somewhat assuming it can't be based on the docs specifying json.)

  • It also might be nice if I could just put raw json into the flag, rather than making a local file for it. But I can work around this with a small bash wrapper function I think that just makes the file and cleans it up afterward. I have a habit of leaving random files around my home directory that I have to clean up later.

Since both of those feature suggestions kind of clash in usage, it might make more sense to consider doing one (if not neither) of them. The raw json in the flag idea is mostly just how I imagined the flag worked before I tried it. The yaml idea might be more generally useful to other people.

This is actually my first time replying to a KEP issue here so let me know if there is anything else I can provide to the team here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked for Doc Freeze
Status: Needs Triage
Development

No branches or pull requests

7 participants