Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce compatibility version for Kubernetes control-plane upgrades #4330

Open
1 of 4 tasks
logicalhan opened this issue Nov 6, 2023 · 19 comments · May be fixed by kubernetes/kubernetes#122891
Open
1 of 4 tasks
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@logicalhan
Copy link
Member

logicalhan commented Nov 6, 2023

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Introduce compatibility version in Kubernetes components to enhance Kubernetes control-plane upgrades. See safer Kubernetes upgrades for more details.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 6, 2023
@jeremyrickard
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 7, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Jan 19, 2024

/sig architecture

@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Jan 19, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Jan 23, 2024

/milestone 1.30

@k8s-ci-robot
Copy link
Contributor

@jpbetz: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jpbetz added a commit to jpbetz/kubernetes that referenced this issue Jan 23, 2024
We won't need to do this manually forever. Long term kubernetes/enhancements#4330 will set it.  But for now we bump it for each release.
@jpbetz
Copy link
Contributor

jpbetz commented Jan 23, 2024

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 23, 2024
@johnbelamaric
Copy link
Member

/lead-opted-in

@jpbetz
Copy link
Contributor

jpbetz commented Feb 6, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 6, 2024
@mickeyboxell
Copy link

Hello @logicalhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze today ([02:00 UTC Friday 9th February 2024 / 18:00 PDT Thursday 8th February 2024](https://everytimezone.com/s/1ade3dca)):.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • Make sure to update your status to implementable in the kep.yaml file.
  • Please let me know when this enhancement is

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@mickeyboxell
Copy link

mickeyboxell commented Feb 9, 2024

Hello 👋, v1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in {current release}, please file an exception request. Thanks!

  • It looks like you still need to update the KEP status to implementable for latest-milestone: 1.30.

@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 9, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Feb 9, 2024

This is due to a clerical error. #4395 was intended to be the KEP PR but we neglected to notice is was still marked as provisional. #4502 fixes this.

@salehsedghpour
Copy link
Contributor

@jpbetz Please make sure that #4502 is being merged and also consider filing an exception request.

@jpbetz
Copy link
Contributor

jpbetz commented Feb 9, 2024

@jpbetz Please make sure that #4502 is being merged and also consider filing an exception request.

#4502 is merged. Do we need a full exception for a clerical error like this?

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 9, 2024

With #4502 being merged, this Enhancements is now tracked for the enhancements freeze. No need to file an exception.

@liggitt liggitt added this to the v1.30 milestone Feb 9, 2024
@liggitt liggitt added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 9, 2024
@kcmartin
Copy link

Hi @jpbetz,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@drewhagen
Copy link
Member

drewhagen commented Feb 15, 2024

Hello @jpbetz 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@mickeyboxell
Copy link

Hey again @jpbetz 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@mickeyboxell
Copy link

mickeyboxell commented Mar 5, 2024

Hey @jpbetz 👋 Enhancements team here, just a friendly reminder to follow up on the open Enhancement items above prior to code freeze at 02:00 UTC Wednesday 6th March 2024.

@jpbetz
Copy link
Contributor

jpbetz commented Mar 5, 2024

@siyuanfoundation @liggitt @deads2k and I discussed this enhancement. We've got a core implementation that's looking good, but it needs to integrate seamlessly in with feature gates, and in particular feature gates in composed sub-components (e.g. a feature gated client-go composed inside some other component that has it's own feature gates).

We've decided to defer merging the implementation until the start of the 1.31 merge window. This both de-risks the 1.30 release and gives us time to more fully get this ready.

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Deferred
Development

Successfully merging a pull request may close this issue.

10 participants