Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed DNS search string validation #4427

Open
2 of 4 tasks
sethev opened this issue Jan 22, 2024 · 16 comments
Open
2 of 4 tasks

Relaxed DNS search string validation #4427

sethev opened this issue Jan 22, 2024 · 16 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@sethev
Copy link
Contributor

sethev commented Jan 22, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 22, 2024
@sethev
Copy link
Contributor Author

sethev commented Jan 22, 2024

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2024
@thockin thockin self-assigned this Jan 24, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Feb 2, 2024

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 2, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Feb 2, 2024

@thockin This one needs /label lead-opted-in

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@AnaMMedina21
Copy link

Hello @sethev 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage <insert-stage-here> for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • [] KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sethev
Copy link
Contributor Author

sethev commented Feb 8, 2024

@AnaMMedina21 working on the implementable field (#4493)

Does the description update look ok?

@AnaMMedina21
Copy link

@sethev Looks great! Will keep an eye out for #4493

@sethev
Copy link
Contributor Author

sethev commented Feb 9, 2024

@AnaMMedina21 status set to implementable!

This enhancement is targeting for stage for v1.30 (correct me, if otherwise)

This is targeting alpha for v1.30

@meganwolf0
Copy link

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@chanieljdan
Copy link

Hi @sethev @thockin 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@a-mccarthy
Copy link

Hi @thockin and @sethev,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@chanieljdan
Copy link

Hi @sethev @thockin 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @sethev @thockin 👋, could you review the above before the placeholder deadline tonight? Thanks!

@sethev
Copy link
Contributor Author

sethev commented Feb 22, 2024

@chanieljdan opened a place holder here: kubernetes/website#45299

@AnaMMedina21
Copy link

Hey again @sethev 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@sethev
Copy link
Contributor Author

sethev commented Mar 5, 2024

@AnaMMedina21 i should have a PR submitted tomorrow, but it looks like i've missed the code freeze for 1.30 :(

@drewhagen
Copy link
Member

drewhagen commented Mar 20, 2024

👋 Hello @sethev

‼️ This KEP needs documentation with a review complete by Doc Freeze on March 26th 18:00 PT (coming up quick!) to get this into the release. After that date, an exception needs to be filed and may risk this feature not getting released with 1.30.

The start of a review was due a week ago, and I see that the documentation is still a draft. Both SIG-Docs and a technical reviewer from SIG network needs to review documentation by that March 26th date.

As a user of Kubernetes, I really appreciate your contribution with good documentation to help me understand how to utilize your new enhancement. Thanks!

@salehsedghpour
Copy link
Contributor

This PR was labeled tracked for code freeze by mistake. As it doesn't have any PR, I'm removing this from milestone.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
Status: Removed from Milestone
Development

No branches or pull requests

10 participants