Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Distribution for Services #4444

Open
4 tasks
gauravkghildiyal opened this issue Jan 26, 2024 · 15 comments
Open
4 tasks

Traffic Distribution for Services #4444

gauravkghildiyal opened this issue Jan 26, 2024 · 15 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network.
Milestone

Comments

@gauravkghildiyal
Copy link
Member

gauravkghildiyal commented Jan 26, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 26, 2024
@gauravkghildiyal
Copy link
Member Author

/assign

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 31, 2024
@thockin thockin added this to the v1.30 milestone Jan 31, 2024
@thockin
Copy link
Member

thockin commented Jan 31, 2024

Marking this opted-in, though it may or may not make the cut, let's try.

@AnaMMedina21
Copy link

AnaMMedina21 commented Feb 7, 2024

Hello @gauravkghildiyal 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@gauravkghildiyal
Copy link
Member Author

Hello @AnaMMedina21 -- the KEP PR has merged. Does this mean we are all good for 1.30?

@AnaMMedina21
Copy link

@gauravkghildiyal Hi!
Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@chanieljdan
Copy link

Hi @gauravkghildiyal 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@a-mccarthy
Copy link

Hi @gauravkghildiyal,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@chanieljdan
Copy link

Hi @gauravkghildiyal 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @gauravkghildiyal 👋, just wanted to follow up here, if you could review before the placeholder deadline tomorrow that would be great!

@gauravkghildiyal
Copy link
Member Author

Thanks for the reminder @chanieljdan . I've created the draft PR at kubernetes/website#45276 and updated the issue description.

@AnaMMedina21
Copy link

Hey again @gauravkghildiyal 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@gauravkghildiyal
Copy link
Member Author

Hi @AnaMMedina21 -- Update: The code changes have been merged.

@salehsedghpour
Copy link
Contributor

Hello @gauravkghildiyal 👋 , Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.30 Code Freeze!

@gauravkghildiyal
Copy link
Member Author

FYI for someone monitoring, the docs are ready for review at kubernetes/website#45276. Thanks!

@gauravkghildiyal gauravkghildiyal changed the title Routing Preference for Services Traffic Distribution for Services Mar 23, 2024
@lzhecheng
Copy link

lzhecheng commented Mar 27, 2024

Hello @gauravkghildiyal, is this feature completed? Does it need code change in CNI side? Thanks.

I enable feature gate in apiserver, kcm and kube-proxy but it still doesn't work.

@gauravkghildiyal
Copy link
Member Author

Hi @lzhecheng, yes as far as I evaluated, this should not be requiring any more changes if you are using kube-proxy. Let's connect over slack if this needs discussion (would prefer to not use this issue for debugging)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
Status: Tracked for Doc Freeze
Development

No branches or pull requests

8 participants