/sig node
/milestone v1.12

@tallclair --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

Set the following:

• Description
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!
/kind feature
/stage alpha

LGTM

Thanks for the update! This has been added to the 1.12 Tracking sheet.

Hey there! @tallclair I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@zparnold what are the docs expectations for alpha features?

Hey @tallclair I think in order to get usage out of the feature it's best to document it in the same way it would be a beta/GA feature. Then if people file issues against it we can improve the feature/docs. What do you think?

Are there any docs on the available options about RuntimeClassName to be able to leverage this feature?

kubernetes/website#10102 will provide the documentation, but it's not written yet.

Unless you're looking for https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

From #k8s-conformance slack conversation https://kubernetes.slack.com/archives/C78F00H99/p1605209694093700:

From what I recall, two weeks as a flakiness check was not based on data. I would be open to adjusting that if the data shows that tests with say 1 week or 10 days of clean runs are highly likely to have 2 weeks of clean runs. @johnbelamaric

i'm open to that too @smarterclayton

If we can get solid conformance tests on these endpoints this week, this should allow 7-10 days of non-flakey CI runs:

https://apisnoop.cncf.io/conformance-progress/endpoints/1.20.0?filter=promoted-without-tests

@hh thank you for that additional context and input.

@SergeyKanzhelev could you please open a code freeze exception request for this (assuming you won't have a PR for this merged by code freeze today). Otherwise, I think we'll need to talk about reverting this for the 1.20 release, as it's lacking the conformance tests.

@SergeyKanzhelev could you please open a code freeze exception request for this (assuming you won't have a PR for this merged by code freeze today). Otherwise, I think we'll need to talk about reverting this for the 1.20 release, as it's lacking the conformance tests.

Can you please help me with this? Where I can read about exception process/form?

@SergeyKanzhelev oh sorry! I thought I had linked it above! 😞

You can find the process documented here.

In essence:

Enhancement Owners
To file for an exception, please fill out the questions below:

Enhancement name:
Enhancement status (alpha/beta/stable):
SIG:
k/enhancements repo issue #:
PR #’s:
Additional time needed (in days):
Reason this enhancement is critical for this milestone:
Risks from adding code late: (to k8s stability, testing, etc.)
Risks from cutting enhancement: (partial implementation, critical customer usecase, etc.)
Email them to:

Your SIG's mailing list
release-team@kubernetes.io
kubernetes-sig-release@googlegroups.com

We'll need to know how many days you'll need for the work to get the tests turned around.

Thanks so much!!

sure. Since tests freeze is 23rd - should I already file an exception? Or if PR will be merged tomorrow it will be fine?

(I know, this is not ideal and should have known about these tests before)

@SergeyKanzhelev

Code Freeze requires: "All enhancements going into the release must be code-complete, including tests"

So yes you will need to file an exception as this test is a requirement for your feature to be GA - as of now it is not complete. Please file an exception ASAP (Jeremy linked above).

Hi @SergeyKanzhelev

Code Freeze is now in effect. As discussed above, you will need to file an Exception.

Best,
Kirsten

An exception was filed and granted:
https://groups.google.com/g/kubernetes-sig-release/c/0b5SQLz2tZg/m/6x26WRccAgAJ

/milestone v1.20

As an update: kubernetes/kubernetes#96551 has merged and we are waiting for sufficient runs to promote to conformance via another pr (kubernetes/kubernetes#96551 (comment))

Looks like the conformance tests are in. Updating the tracking sheet.

@kikisdeliveryservice thank you!

Congrats on the Conformance Test Promotion:

https://apisnoop.cncf.io/1.20.0/stable/node

https://apisnoop.cncf.io/conformance-progress/endpoints/1.20.0?filter=promoted-with-tests

@tallclair can you please fix the link in the issue description to: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/585-runtime-class

Hey @SergeyKanzhelev @tallclair

Since this is now GA and the KEP has an implemented status, you can close this tracking issue.

Thanks!
Kirsten

/close

It will be great if somebody can fix the description of the issue as this issue is linked from the 1.20 release notes and the link to actual description is broken.

@SergeyKanzhelev: Closing this issue.

I fixed it earlier @SergeyKanzhelev ☺️