Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move frequent Kubelet heartbeats to Lease API #589

Closed
6 tasks done
mtaufen opened this issue Jul 17, 2018 · 49 comments · Fixed by #1402
Closed
6 tasks done

Move frequent Kubelet heartbeats to Lease API #589

mtaufen opened this issue Jul 17, 2018 · 49 comments · Fixed by #1402
Assignees
@wangzhen127 @dchen1107 @yujuhong @wojtek-t
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone
v1.17

Comments

@mtaufen
Copy link
Contributor

mtaufen commented Jul 17, 2018 •
edited by wojtek-t

Feature Description
@mtaufen mtaufen added sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Jul 17, 2018
@mtaufen mtaufen added this to the v1.12 milestone Jul 17, 2018
@mtaufen mtaufen self-assigned this Jul 17, 2018
@mtaufen mtaufen added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 17, 2018
@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 18, 2018
@justaugustus
Copy link
Member

@mtaufen --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@mtaufen
Copy link
Contributor Author

mtaufen commented Jul 19, 2018

@justaugustus this is ready to be included in the v1.12 milestone.

Thanks!

@justaugustus
Copy link
Member

Added. Thanks for confirming, @mtaufen!

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 22, 2018
@mtaufen mtaufen mentioned this issue Aug 1, 2018
Closed
@mtaufen mtaufen modified the milestones: v1.12, v1.13 Aug 15, 2018
@mtaufen
Copy link
Contributor Author

mtaufen commented Aug 15, 2018

We decided to push this to 1.13, given the limited time we have left.
Additionally, @wangzhen127 is going to own this feature going forward, as I have been pulled into other work.

@mtaufen
Copy link
Contributor Author

mtaufen commented Aug 15, 2018

We will still try to merge kubernetes/kubernetes#66257 for 1.12, since it is almost done and we don't want it to rot.

@kacole2
Copy link
Contributor

kacole2 commented Aug 15, 2018

thanks for the update @mtaufen this has been removed from the 1.12 tracking sheet and added to the tab Removed from Milestone.

cc @justaugustus

@justaugustus
Copy link
Member

@mtaufen -- thanks for being proactive about updating us!
@kacole2 -- thanks for getting the sheet updated

/unassign @mtaufen
/assign @wangzhen127

@justaugustus justaugustus added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 15, 2018
@justaugustus justaugustus removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 27, 2018
justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018
Merge pull request kubernetes#589 from jsafrane/containerized-mount
d1aa461 
Automatic merge from submit-queue.

Proposal: containerized mount utilities in pods

@kubernetes/sig-storage-proposals  @kubernetes/sig-node-proposals
This was referenced Sep 28, 2018
Merged
Merged
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 8, 2018
@wojtek-t
Copy link
Member

I decided that we will wait for one more release to graduate to GA to get a bit more feedback about the feature.

/tracked no

@wojtek-t wojtek-t modified the milestones: v1.16, v1.17 Jul 30, 2019
@wojtek-t wojtek-t added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 30, 2019
@wojtek-t wojtek-t mentioned this issue Sep 12, 2019
Merged
@mrbobbytables
Copy link
Member

Hey there @wojtek-t @wangzhen127 -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

Monday, September 23 - Release Cycle Begins
Tuesday, October 15, EOD PST - Enhancements Freeze
Thursday, November 14, EOD PST - Code Freeze
Tuesday, November 19 - Docs must be completed and reviewed
Monday, December 9 - Kubernetes 1.17.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@wojtek-t
Copy link
Member

Yes - 1.17 is the current plan for GA.

@mrbobbytables
Copy link
Member

Awesome, thanks! I'll add it to the tracking sheet.
/stage stable

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 24, 2019
@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 24, 2019
This was referenced Oct 9, 2019
Merged
Merged
Merged
@wojtek-t wojtek-t mentioned this issue Oct 16, 2019
Merged
@VineethReddy02
Copy link

@wojtek-t @wangzhen127

I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks!

@wojtek-t
Copy link
Member

Yes - it will require small docs PR to update feature status. I will send it out before deadline.

This was referenced Oct 24, 2019
Merged
Merged
Merged
@annajung
Copy link
Contributor

annajung commented Nov 6, 2019

Hey @wojtek-t 1.17 Enhancement Shadow here! 👋 I am reaching out to check in with you to see how this enhancement is going.

The Enhancement team is looking to track k/k PRs that are related to this enhancement. I see that you have referenced this in kubernetes/kubernetes#84351 which have been added to the tracking sheet as part of this enhancement. Are there any other k/k PRs that need to be tracked as well?

Also, another friendly reminder that we're quickly approaching code freeze (Nov. 14th).

@wojtek-t
Copy link
Member

wojtek-t commented Nov 6, 2019

kubernetes/kubernetes#84351
and docs PR: kubernetes/website#17189

@wojtek-t wojtek-t mentioned this issue Dec 10, 2019
Merged
@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@mmiranda96 mmiranda96 mentioned this issue Sep 16, 2021
Closed
@timebertt timebertt mentioned this issue Dec 15, 2022
Closed
@MartinWeindel MartinWeindel mentioned this issue Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangzhen127 wangzhen127

@dchen1107 dchen1107

@yujuhong yujuhong

@wojtek-t wojtek-t

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Milestone
v1.17
Development

Successfully merging a pull request may close this issue.

Mark NodeLease KEP as implemented wojtek-t/enhancements