Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduling Framework #624

Closed
bsalamat opened this issue Oct 1, 2018 · 53 comments
Closed

Scheduling Framework #624

bsalamat opened this issue Oct 1, 2018 · 53 comments
Assignees
@bsalamat
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@bsalamat
Copy link
Member

bsalamat commented Oct 1, 2018 •
edited

Feature Description

  • One-line feature description (can be used as a release note): Implement a scheduling framework where many of the existing and future features of the existing scheduler can be written as plug-ins for the scheduler.
  • Primary contact (assignee): @bsalamat
  • Responsible SIGs: scheduling
  • Design proposal link (KEP): https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20180409-scheduling-framework.md
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @k82cn @misterikkit
  • Approver (likely from SIG/area to which feature belongs): @k82cn @bsalamat
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.15
    • Beta release target (x.y) 1.17
    • Stable release target (x.y)

This is a long term project and requires many changes to the existing scheduler. In order to ensure quality and reliability of the scheduler, we plan to build the features gradually and in steps. The first extension points are targeted for 1.13. We will add more extension points in the future releases. We will prioritize the addition of the extension points based on need for them.

/sig scheduling
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 1, 2018
@kacole2 kacole2 added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Oct 8, 2018
@bsalamat bsalamat mentioned this issue Oct 25, 2018
Merged
@misterikkit misterikkit mentioned this issue Jan 2, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2019
@mlmhl
Copy link

mlmhl commented Jan 7, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2019
@claurence
Copy link

@bsalamat Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - I don't see a relevant KEP for this issue can you drop the link to the KEP? Thanks

@bsalamat bsalamat mentioned this issue Mar 29, 2019
Merged
@bsalamat
Copy link
Member Author

KEP for this enhancement is found at: https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20180409-scheduling-framework.md

@kacole2
Copy link
Contributor

kacole2 commented Apr 12, 2019

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@kacole2 kacole2 removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Apr 12, 2019
@justaugustus
Copy link
Member

/assign @bsalamat

@bsalamat
Copy link
Member Author

@kacole2 Yes, this feature is going to be alpha in 1.15.
One PR which was merged a while back is referenced above is: kubernetes/kubernetes#70227
Another PR which will be merged soon: kubernetes/kubernetes#75848
I would expect to see a number of more PRs in the new future. I will make sure that they reference this issue.

@kacole2
Copy link
Contributor

kacole2 commented Apr 30, 2019

/milestone v1.15
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 30, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 30, 2019
@kacole2
Copy link
Contributor

kacole2 commented Apr 30, 2019

@bsalamat, After reviewing your KEP, it's currently in a draft state. It must be "implementable" to be included in 1.15. In addition, it's missing test plans and graduation criteria which is required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019.

@bsalamat bsalamat mentioned this issue Apr 30, 2019
Merged
@bsalamat
Copy link
Member Author

@kacole2 Thanks for the reminder. I just sent #1026 to add test plans, graduation criteria, and change status to 'implementable'.

This was referenced Apr 30, 2019
Closed
Closed
Closed
This was referenced May 7, 2019
Closed
Merged
This was referenced May 7, 2019
Closed
Closed
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2020
@ahg-g
Copy link
Member

ahg-g commented Jul 31, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2020
@kikisdeliveryservice
Copy link
Member

Hi @ahg-g

Enhancements Lead here. Are there any plans to graduate this to beta in 1.20?

Thanks!
Kirsten

@ahg-g
Copy link
Member

ahg-g commented Sep 14, 2020

Hi kikisdeliveryservice@, this feature is not guarded by a feature flag and there is really no notion of versions for this api yet. We may declare this as implemented and graduated in 1.20 and close this issue.

@ahg-g ahg-g mentioned this issue Sep 14, 2020
Closed
@kikisdeliveryservice
Copy link
Member

Thanks @ahg-g ! For now I will track this enhancement and just keep us updated 👍

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 14, 2020
@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Sep 14, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 27, 2020 •
edited

Hi @ahg-g

Any update as to whether this is going to get marked as implemented? I see that you got some agreement on doing so, but want to check.

Thanks
Kirsten

@ahg-g
Copy link
Member

ahg-g commented Sep 28, 2020

I opened an issue for discussion: kubernetes/kubernetes#95037 there doesn't seem to be any objection so far, I will wait few more days and then send a PR to change the KEP to implemented.

@kikisdeliveryservice
Copy link
Member

Thanks for the update @ahg-g !!

@ahg-g
Copy link
Member

ahg-g commented Oct 2, 2020

PR for marking this as implemented: #2054

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 5, 2020 •
edited

The above PR merged marking 624 as implemented in 1.19.

Please feel free to close this issue.

Thanks @ahg-g !!

@kikisdeliveryservice kikisdeliveryservice added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Oct 5, 2020
@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Oct 5, 2020
@zhiyu0729 zhiyu0729 mentioned this issue Nov 27, 2020
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 2, 2021
@ahg-g
Copy link
Member

ahg-g commented Feb 2, 2021

/close

This is done.

@k8s-ci-robot
Copy link
Contributor

@ahg-g: Closing this issue.

In response to this:

/close

This is done.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsalamat bsalamat

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests