Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Resource Metrics Endpoint #727

Closed
8 of 10 tasks
dashpole opened this issue Jan 24, 2019 · 88 comments · Fixed by kubernetes/kubernetes#116897
Closed
8 of 10 tasks

Kubelet Resource Metrics Endpoint #727

dashpole opened this issue Jan 24, 2019 · 88 comments · Fixed by kubernetes/kubernetes#116897
Assignees
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@dashpole
Copy link
Contributor

dashpole commented Jan 24, 2019

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 24, 2019
@dashpole
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 24, 2019
@dchen1107 dchen1107 added this to the v1.14 milestone Jan 25, 2019
@dchen1107 dchen1107 added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 25, 2019
@claurence claurence added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 25, 2019
@claurence
Copy link

@dashpole I've added this enhancement to the 1.14 tracking doc since it looks like y'all are targeting alpha here.

Are there any open PRs for this that should be tracked as well for it to be added to 1.14 as alpha?

@dashpole
Copy link
Contributor Author

@claurence I am going to wait until the KEP is approved to open PRs. Ill reference this feature issue from the PRs if/when that happens

@WanLinghao
Copy link

/cc

@claurence
Copy link

@dashpole since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019
@claurence claurence added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 30, 2019
@dashpole
Copy link
Contributor Author

@claurence where is it specified that KEPs must be merged by feature freeze?
In previous releases the only requirement was to have this issue open.

@dashpole
Copy link
Contributor Author

@claurence
https://github.com/kubernetes/sig-release/tree/master/releases/release-1.14#enhancements-freeze states:

"By Tuesday January 29, 2019 all enhancements landing in v1.14.0 must ... have an associated KEP merged or in progress in kubernetes/enhancements, linked to in the description of the tracking issue"

@claurence
Copy link

Hey @dashpole apologies as our docs have been changing a bit today - given feedback we've heard we are going to be lenient with KEPs though we want them merged by Feb 4th.

@claurence claurence added this to the v1.14 milestone Feb 6, 2019
@claurence claurence added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 7, 2019
@claurence
Copy link

Added back to 1.14 per exception request submitted and approved

@npentrel
Copy link

Hey @dashpole 👋! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@kacole2
Copy link
Contributor

kacole2 commented Apr 12, 2019

Hello @dashpole , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Apr 12, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 12, 2019
@dashpole
Copy link
Contributor Author

@kacole2 I don't have any plans to graduate this in 1.15

@logicalhan
Copy link
Member

Hello @richabanker @dashpole 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting for stage stable for v1.28

Question: Is this enhancement directly jumping from stage alpha to stable?

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone:v1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

We're going to delay graduation for one more release (v1.29).

@richabanker
Copy link
Contributor

/milestone v1.29

@k8s-ci-robot
Copy link
Contributor

@richabanker: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@npolshakova
Copy link

Hi @richabanker, 1.29 enhancement team here! Is this enhancement targeting 1.29? If it is, can you reopen the issue and follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@wojtek-t wojtek-t reopened this Sep 28, 2023
@wojtek-t
Copy link
Member

/milestone v1.29
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, v1.29 Sep 28, 2023
@npolshakova
Copy link

Hi @richabanker 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

It looks like #4037 will address most of these issues. One thing to note- the KEP should only be marked after the all code PRs are merged and feature gates are removed. Since there are no feature gate involved for this and kubernetes/kubernetes#116897 has merged, this is fine to mark the KEP as implemented. Please let me know if that's not the case!

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova
Copy link

Hi @richabanker, just checking in once more as we approach the 1.29 enhancement freeze deadline this week on 01:00 UTC, Friday, 6th October, 2023. With #4037 merged, the status of this enhancement is marked as tracked for enhancement freeze! 🚀

@katcosgrove
Copy link

Hey there @dashpole and @richabanker! 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@richabanker
Copy link
Contributor

@dashpole do you think we need any updates in the existing docs for kubelet resource metrics?

@dashpole
Copy link
Contributor Author

@richabanker I don't think so.

@kcmartin
Copy link

Hi @dashpole @richabanker! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@logicalhan
Copy link
Member

@richabanker I don't think so.

I actually think we should: https://kubernetes.io/docs/reference/instrumentation/node-metrics/ doesn't seem to include the resource metrics endpoint.

@logicalhan
Copy link
Member

Also the existing documentation: https://kubernetes.io/docs/tasks/debug/debug-cluster/resource-metrics-pipeline/ is weirdly located and doesn't have much information about kubelet resource metrics.

@richabanker
Copy link
Contributor

There's a brief mention of the endpoint itself
image but lacks details yeah.

@npolshakova
Copy link

Hey again @richabanker 👋 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs has merged and update in the Issue description:

With this pr merged, if there are no additional code PRs, please update the status as implemented since there are no feature gates for this feature.

The status of this KEP is tracked for code freeze. 🚀

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@salehsedghpour
Copy link
Contributor

Hi @richabanker , 👋 1.30 Enhancements lead here
As it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

@richabanker
Copy link
Contributor

Hi @richabanker , 👋 1.30 Enhancements lead here As it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

Ack'd @salehsedghpour , created a PR #4388, and will close the issue once this is merged. Thanks!

@salehsedghpour
Copy link
Contributor

Awesome and Thanks!

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

I'm closing milestone 1.29 now,

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@richabanker
Copy link
Contributor

/close
since #4388 is now merged.

@k8s-ci-robot
Copy link
Contributor

@richabanker: Closing this issue.

In response to this:

/close
since #4388 is now merged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Deferred
Status: Tracked for Code Freeze