Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce v1alpha2 kube-proxy component config version #784

Open
luxas opened this issue Jan 30, 2019 · 78 comments
Open

Introduce v1alpha2 kube-proxy component config version #784

luxas opened this issue Jan 30, 2019 · 78 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.

Comments

@luxas
Copy link
Member

luxas commented Jan 30, 2019

  • One-line enhancement description (can be used as a release note): Usage of the kube-proxy configuration file has graduated from experimental, as the API version now is v1beta1
  • Primary contact (assignee): @luxas
  • Responsible SIGs: @kubernetes/sig-network-api-reviews @kubernetes/wg-component-standard
  • KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/784-kube-proxy-component-config
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @thockin
  • Approver (likely from SIG/area to which enhancement belongs): @thockin
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) PAST
    • Beta release target (x.y) 1.16
    • Stable release target (x.y) TODO

The kube-proxy ComponentConfig is currently in v1alpha1. The spec needs to be graduated to v1beta1 and beyond in order to be usable widely.
/assign @thockin

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jan 30, 2019
@luxas luxas added this to the v1.14 milestone Jan 30, 2019
@luxas luxas added the wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. label Jan 30, 2019
@liggitt liggitt added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 31, 2019
@sttts
Copy link
Contributor

sttts commented Jan 31, 2019

We need a thorough API review of the kube-proxy component config in the light of unifying them for all components. Moving what we have to beta in the 1.14 time frame feels like rushing in the light of us having just started with component-base.

@claurence
Copy link

@luxas I don't see a KEP for this issue links in the description. I'm removing it from the 1.14 milestone - to have it added back please file an exception request.

@rosti
Copy link
Contributor

rosti commented Mar 19, 2019

I am giving this a try.
/assign

@kacole2
Copy link
Contributor

kacole2 commented Apr 11, 2019

@luxas @rosti I'm the enhancement lead for 1.15. I don't see a KEP filed for this enhancement and per the guidelines, all enhancements will require one. Please let me know if this issue will have any work involved for this release cycle and update the original post reflect it. Thanks!

@rosti
Copy link
Contributor

rosti commented Apr 16, 2019

@kacole2 I am a bit skeptical for a KEP in this release cycle, however if we manage to put something before enhancements freeze for 1.15 then we'll ping you.

@rosti
Copy link
Contributor

rosti commented Jun 5, 2019

Initial proposal doc.
This is shared with WG Component Standard, SIG Network, SIG Windows, SIG API Machinery and SIG Cluster Lifecycle. If someone has trouble accessing it, ping me.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 5, 2019

@rosti thanks for picking this up! The common vs. local and per-platform config problems have needed someone who can really focus on them for a while, and I haven't been able to dedicate enough time lately. So I'm grateful someone's looking at this :). This is critical to the future of the componentconfig effort.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 5, 2019

I left some comments on your doc.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 6, 2019

@vllry, I heard you're also going to be working on kube-proxy componentconfig, wanted to make sure you see this.

@stealthybox
Copy link
Member

@rosti, shall we tag this /w 1.16 and update KEP #1104?

@alejandrox1
Copy link
Contributor

Moving this to the 1.16 milestone to tackle during the next release
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 26, 2019
@neolit123 neolit123 added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 26, 2019
@neolit123
Copy link
Member

IMO we should have k/enhancements issues that track full graduation of APIs. from alpha->GA instead of separate ones for beta or GA.

@rosti
Copy link
Contributor

rosti commented Jul 1, 2019

If the KEP merges we can have an alpha version released before the end of the cycle, so I think, that it's appropriate to have it in 1.16.

@mrbobbytables
Copy link
Member

Hey there @luxas, I'm one of the 1.16 Enhancement Shadows. Looks like you're on track for v1.16 :)

As a general reminder, the KEP must be merged and in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@mrbobbytables mrbobbytables added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 10, 2019
@danwinship
Copy link
Contributor

/remove-lifecycle stale
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

@danwinship: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/remove-lifecycle stale
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor

@danwinship: Can not set label lead-opted-in: Must be member in one of these teams: [... sig-network-leads ...]

um?

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@thockin thockin added this to the v1.30 milestone Feb 2, 2024
@aroradaman
Copy link
Member

/retitle Graduate the kube-proxy ComponentConfig to v1alpha2

@k8s-ci-robot k8s-ci-robot changed the title Graduate the kube-proxy ComponentConfig to v1beta1 Graduate the kube-proxy ComponentConfig to v1alpha2 Feb 4, 2024
@aroradaman
Copy link
Member

aroradaman commented Feb 4, 2024

Link to PR with the updated proposal, design, and PRR questionnaire of KEP: #4337

@aroradaman
Copy link
Member

/retitle Introduce v1alpha2 kube-proxy component config version

@k8s-ci-robot k8s-ci-robot changed the title Graduate the kube-proxy ComponentConfig to v1alpha2 Introduce v1alpha2 kube-proxy component config version Feb 5, 2024
@pnbrown
Copy link

pnbrown commented Feb 7, 2024

Hello @jayunit100 @rikatz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@neolit123
Copy link
Member

neolit123 commented Feb 7, 2024

@pnbrown hello, not sure what is in the release team role book on this one, but it's better to ping the "assigned" folks and not the author of the ticket.

@pnbrown
Copy link

pnbrown commented Feb 7, 2024

@neolit123 my apologies. I'll fix.

@aroradaman
Copy link
Member

/assign

@chanieljdan
Copy link

Hi @jayunit100 @rikatz 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@a-mccarthy
Copy link

Hi @jayunit100 and @rikatz,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@chanieljdan
Copy link

Hi @jayunit100 @rikatz 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @jayunit100 @rikatz @aroradaman 👋, just want to follow up on this, if you could review, thanks!

@rikatz
Copy link
Contributor

rikatz commented Feb 21, 2024

Hi, tbh I have no idea on the status of this feature

@aroradaman
Copy link
Member

Hi @jayunit100 @rikatz @aroradaman 👋, just want to follow up on this, if you could review, thanks!

@chanieljdan I have created the placeholder PR.

@pnbrown
Copy link

pnbrown commented Feb 29, 2024

Hey again @jayunit100 @rikatz @aroradaman 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@danwinship
Copy link
Contributor

/unassign @jayunit100 @rikatz
to avoid confusion since they're not currently working on this

@salehsedghpour
Copy link
Contributor

Hello @aroradaman 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.30 milestone.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
Status: Removed from Milestone
Development

No branches or pull requests