/sig node

/assign @derekwaynecarr

/kind api-change

/milestone v1.15

@matthyx: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

/stage alpha

@kacole2 the feature is implemented in this PR: kubernetes/kubernetes#71449

@matthyx Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

Hi Bob!
Please have a look at #1014
I have already talked to @derekwaynecarr to have a look, he suggested adding a feature gate to the document, which I did.
I am also waiting for some feedback from @thockin after answering his concerns.

@matthyx Great! Thanks for the info :) Will keep an eye on #1014

@mrbobbytables I haven't heard of them during the night... not sure we'll meet the deadline :-(

@mrbobbytables I have the support of @thockin for this KEP, can we maintain it in 1.15?
We're just discussing the implementation now, but the fundamentals are more or less agreed upon.

@matthyx Enhancement Freeze for Kubernetes 1.15 has passed and this unfortunately did not meet the deadline. It's being removed from the 1.15 milestone and the tracking sheet, but it looks like you're already on track to get an Enhancement Exception in. 👍 Thanks for being on point about it :)

/milestone v1.15

Sure.

/milestone v1.20

Enhancement Description

• One-line enhancement description (can be used as a release note): adds initializationFailureThreshold to probes allowing a greater number of failures during the initial start of the container.

• Kubernetes Enhancement Proposal: 20190221-livenessprobe-holdoff

• Primary contact (assignee): @matthyx

• Responsible SIGs: @kubernetes/sig-node-api-reviews

• Enhancement target (which target equals to which milestone):

  • Alpha release target (x.y) v1.16
  • Beta release target (x.y) v1.XY
  • Stable release target (x.y) v1.XY

Glad to hear this

@qixiaobo: Reiterating the mentions to trigger a notification:
@kubernetes/sig-node-api-reviews

Hi @matthyx !

Enhancements Lead here, do you still intend to go GA in 1.20?

Thanks!
Kirsten

Hi @kikisdeliveryservice

I actually did already with this PR: kubernetes/kubernetes#94160
I just need to merge the corresponding doc: kubernetes/website#23332

@matthyx Perfect thank you for the update!

Also just as a reminder once this feature totally complete and all of your PRs are merged, please update the kep to have a status of implemented: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20190221-livenessprobe-holdoff.md

sure!

Hi @matthyx 👋!

I'm one of the Enhancement shadows for the 1.20 release cycle. Not exactly relevant to this KEP since it's almost completed, but the Enhancement freeze is on the 6th of Oct.

It looks like one of the last things to do is to get the following PR (#1988) merged to move this KEP to implemented, there's one lgtm at this point and i guess there's someone you can poke at to get it approved!

Thanks!

Keeping this open for tracking until we close the milestone :)

Hello, 1.21 Enhancement lead here.
I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

@annajung: Closing this issue.

Thanks @annajung !